#1357 ✓ staged
Scott Downe

we're calling start before setup on an update

Reported by Scott Downe | October 16th, 2012 @ 12:29 PM | in 1.4

Example, if the start turns on an div, displays it in some way, but setup has not yet been called, it ends up referencing the old div, the one that was removed from the dom.

Then when the setup is called, it adds a new div that is not on.

Comments and changes to this ticket

  • Scott Downe

    Scott Downe October 16th, 2012 @ 12:29 PM

    • Tag set to priority
  • Scott Downe

    Scott Downe October 22nd, 2012 @ 11:08 AM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “Scott Downe” to “mjschranz”
    • Milestone order changed from “172” to “0”

    https://github.com/mozilla/popcorn-js/pull/229

    I had to remove a test that was fairly invalid.

    I figure any changes to a test, should be explained.

    Previously, when we added a new track event, the setup function would be fired before the item was added to the array, and thus checking that byStart had it inside setup should not be supported.

    If a setup happens with or without an update function, we should do the same thing.

    The only time the array should do this is during an update, not a setup.

    So I removed a test that expected this.

  • mjschranz

    mjschranz October 30th, 2012 @ 08:55 PM

    • State changed from “peer-review-requested” to “super-review-requested”
    • Assigned user changed from “mjschranz” to “Rick”
    • Milestone order changed from “24” to “0”

    I feel silly for letting this in like it before, but it's good that this was caught. In either case, I was just waiting to give it some testing in Popcorn Maker.

    Anyway, tests are good and the changes are solid.

    PR+

  • Rick

    Rick October 31st, 2012 @ 02:33 PM

    • State changed from “super-review-requested” to “review-looks-good”
    • Assigned user changed from “Rick” to “Scott Downe”
    • Milestone order changed from “125” to “0”

    This makes sense and looks good. SR+

  • Scott Downe

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Tags

Pages