#153 ✓ resolved
db48x

secondary <video> and <audio> in sync with primary

Reported by db48x | November 26th, 2010 @ 12:54 AM | in 1.0 Release (closed)

My implementation's not quite complete, but it covers the basics. It still needs to handle seeks, and I want to handle / that is already included in the page correctly; currently it always adds new nodes to the document.

git://github.com/db48x/popcorn-js.git

Comments and changes to this ticket

  • db48x
  • db48x

    db48x December 8th, 2010 @ 04:49 PM

    • State changed from “new” to “peer-review-requested”
    • Assigned user set to “db48x”
  • annasob

    annasob December 9th, 2010 @ 08:31 PM

    • Milestone set to 0.2 release
    • Milestone order changed from “13” to “0”
  • annasob

    annasob December 15th, 2010 @ 06:14 PM

    • State changed from “peer-review-requested” to “review-needs-work”

    Hey, i took a look at this. Code looks good but a couple things:
    -1 lets get rid of the JQuery -2 add a popcorn.playlist.html file so that i can see a demo of this and play around with it -3 add some comments so i know what the plugin does and what option parameters can/must be put in.

  • db48x

    db48x December 17th, 2010 @ 01:08 AM

    • State changed from “review-needs-work” to “peer-review-requested”

    All done. There's actually a small bug in popcorn.js that is now preventing these plugins from working, but I'll file that momentarily... done. See ticket 232.

  • annasob

    annasob January 11th, 2011 @ 05:07 PM

    • Milestone changed from 0.2 release to 0.3 release date

    Pushing

  • annasob

    annasob January 21st, 2011 @ 01:40 PM

    • State changed from “peer-review-requested” to “review-needs-work”

    I feel that we need more info on the actual.html page. What is/should be happening. Also since type can be both audio and video we should alter the .html files to include both versions of the plugin. so from 10-20 do audio but from 0-10 do video or something similar.

    One other thing: in the playanother when u put type= video it plays the video but doesnt stop when the time goes past the end option. Furthermore, when you seek back to start the 2nd video continues on. I think we need a way of saying which part of the video should be playing. Not sure what the desired behavior is but definitely needs more comments

  • annasob

    annasob February 8th, 2011 @ 05:32 PM

    • Milestone changed from 0.3 release date to 0.4
  • db48x

    db48x February 21st, 2011 @ 04:03 PM

    • State changed from “review-needs-work” to “peer-review-requested”
  • Rick

    Rick February 22nd, 2011 @ 12:47 PM

    • State changed from “peer-review-requested” to “review-needs-work”

    Have you looked at or tried using the Popcorn event system? The video.listen( "eventType", callback )/ video.trigger( "eventType" ) functions will only register one addEventListener per type, per video element and stores an internal object that keeps track of all callbacks that are associated with any given event type - which means 1 "play" event will fire Nth registered play handlers, instead of many of the same event type executing their own event handlers.

    Can you also take a look at the style guide and update accordingly? https://webmademovies.lighthouseapp.com/projects/63272/styleguide

    Thanks! :D

  • Rick

    Rick February 22nd, 2011 @ 01:44 PM

    I also just noticed that the media files used in your tests are in the main ./test/ dir, Should they be moved to plugins/playlist/data/ ?

  • db48x

    db48x February 22nd, 2011 @ 01:52 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Milestone cleared.
    • Assigned user changed from “db48x” to “cgomes7”

    I also just noticed that the media files used in your tests are in the main ./test/ dir, Should they be moved to plugins/playlist/data/ ?

    Dunno, I put them there simply because that's where the test video is.

  • db48x

    db48x February 22nd, 2011 @ 01:53 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “cgomes7” to “db48x”

    stupid lighthouse

  • David Seifried

    David Seifried September 14th, 2011 @ 07:23 PM

    • Milestone set to 1.0 Release
    • Assigned user cleared.
    • Milestone order changed from “1” to “0”

    I havnt seen db48x in here for a while, gonna open this up to everyone.

  • Rick

    Rick September 14th, 2011 @ 08:13 PM

    • State changed from “review-needs-work” to “resolved”
    • Assigned user set to “Rick”

    I'm going to resolve this for now. If anyone wants to reopen, please do so!

    Otherwise, this polyfill should do the trick:

    https://github.com/rwldrn/mediagroup.js

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages