#241 ✓ checked-in
annasob

Fix options parameter

Reported by annasob | December 24th, 2010 @ 03:59 PM | in 0.2 release

Fix for ticket #239 introduced a new bug. As it is right now the options object is being overwritten with what is in the manifest options even before setup is called. Due to this options.target is no longer what the html page specified it to be but instead what the manifest options.target is.
Take for instance this example:

var p = Popcorn('#video')
 .image({
  start: 5, // seconds
  end: 15, // seconds
  href: 'http://www.drumbeat.org/',
  src: 'http://www.drumbeat.org/sites/default/files/domain-2/drumbeat_logo.png',
  target: 'imagediv'
} );
Options.target should be 'imagediv' but if the plugin-manifest specifies something like:
options:{
 target : 'Image-container'
}
The actual options.target value will be 'Image-container'. This means that the user has no control over what they set target to.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

People watching this ticket

Referenced by

Pages