Comments and changes to this ticket
(from [e7790ab54a98935ff10d7fe169cd63978e233385]) [#244] Prefix internal properties set to 'options' with '_' underscore https://github.com/rwldrn/popcorn-js/commit/e7790ab54a98935ff10d7fe...
- State changed from assigned to peer-review-requested
- Assigned user changed from Rick to annasob
Just like it says, I needed to update internally used properties to be prefixed with an underscore. No new tests, passes all existing tests.
- State changed from peer-review-requested to super-review-requested
I am fine with this, makes sense.
Something unrelated to this ticket, but made me think, I think we should consider using underscores for the start and end properties, just like we do with setup, or, stop using it for setup, to keep things consistent? I am aware this ticket is for the internals to have underscores, so, is setup internal, or is there another reason for setup to have an underscore?
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.