#310 ✓ checked-in
David Humphrey

Not specifying an id on a video causes popcorn to silently fail

Reported by David Humphrey | February 7th, 2011 @ 11:19 PM | in 0.3 release date

Right now, if we don't specify an id on a video element, popcorn.js merrily skips over it, with no warning or other indication of the issue. The comment below from the code indicates this is by design:

      //  Ensure we're looking at a dom node and that it has an id
      //  otherwise Popcorn won't be able to find the video element

I think this is a bad idea. I just spend most of an evening debugging a failed popcorn app with a filmmaker, only to discover she was missing the id. At least this is a documentation issue; but more likely, and imho, this is just broken.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages