#391 ✓ resolved
Dan Mosedale

hard to turn off subtitles

Reported by Dan Mosedale | March 10th, 2011 @ 02:16 PM | in 0.7

I've got a video that I'm displaying with an instance of popcorn and sometimes want to show subtitles in front of, and sometimes not.

The ideal thing to do might be to create an option of some sort to the plugin that allows them to be turned on and off dynamically.

The simpler thing is for the popcorn user to reach in and set "display: hidden" on the div containing the subtitles. Right now, it's a little clumsy to get that div, since it doesn't have an id or a class. A patch giving it a class of "subtitles" shouldn't be too hard to whip up.

Comments and changes to this ticket

  • David Humphrey

    David Humphrey March 14th, 2011 @ 05:22 PM

    • State changed from “new” to “bugs”
    • Milestone set to 0.5
    • Milestone order changed from “45” to “0”

    This bug overlaps with a bunch of other styling bugs related to subtitles. CC'ing Steven. I think it makes sense to expose the div via a well-known id, such that users can style it in css as they see fit. Should we also put a global toggle on the Popcorn instance to override plugins temporarily? I can imagine other cases where one might wish to override what is presently going to happen. Maybe a way to enable/disable all plugins of a particular type on the instance.

  • David Humphrey

    David Humphrey March 16th, 2011 @ 02:29 PM

    Filed bug #414 to add a global toggle for commands of a given type. I think this bug should focus on standard styling of css via documented class/id names.

  • annasob

    annasob March 24th, 2011 @ 04:49 PM

    • Milestone changed from 0.5 to 0.6
    • Milestone order changed from “25” to “0”

    Pushing to 0.6

  • Scott Downe

    Scott Downe April 20th, 2011 @ 02:16 PM

    Interesting idea when it comes to style in plugins.

    Allow a css class (string to the class id?) to be supplied to the plugin, which contains the styling info. This class would be applied to any internal element the plugin creates that makes sense on a plugin by plugin basis. Also, this way you can have multiple tracks sharing one target with different styling. Use classList.add() http://caniuse.com/classlist. Just an idea.

  • Dan Mosedale
  • annasob

    annasob May 10th, 2011 @ 04:36 PM

    • State changed from “bugs” to “blocked”
    • Milestone changed from 0.6 to 0.7
    • Milestone order changed from “7” to “0”

    Blocked on #414 +convo on is this popcorn-js or user's own CSS

  • Scott Downe

    Scott Downe June 2nd, 2011 @ 04:29 PM

    • State changed from “blocked” to “open”

    #414 is done, so this shouldn't be blocked anymore.

  • Scott Downe

    Scott Downe June 2nd, 2011 @ 04:30 PM

    • Assigned user set to “cadecairos”
  • Rick

    Rick June 2nd, 2011 @ 04:44 PM

    So, its unblocked but also resolved. you can "turn off" anything now

  • Scott Downe

    Scott Downe June 2nd, 2011 @ 05:29 PM

    • State changed from “open” to “resolved”

    We have satisfied the original ticket's need with toggle().

    I was just doing a higher level triage, but taking a closer look, I think you are right, this is resolved now.

    The user can create a button that calls these toggle(), disable() and enable() functions.

  • Dan Mosedale

    Dan Mosedale June 2nd, 2011 @ 06:27 PM

    Great; thanks! Will switch to toggle() once I forward port The Band...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins