#392 ✓ checked-in
annasob

Unit tests not passing Lint

Reported by annasob | March 10th, 2011 @ 03:07 PM | in 0.4

Linting ./plugins/code/popcorn.code.js

if ( !options.onStart || !( typeof options.onStart === 'function' ) ) {

Problem at line 104 character 30: Confusing use of '!'.

if ( options.onEnd && !( typeof options.onEnd === 'function' ) ) {

Problem at line 108 character 27: Confusing use of '!'.

if ( options.onFrame && !( typeof options.onFrame === 'function' ) ) {

Problem at line 112 character 29: Confusing use of '!'.

  onEnd: {elem:'input', type:'text', label:'onEnd'},

Problem at line 150 character 56: Extra comma.

Linting ./plugins/lowerthird/popcorn.lowerthird.js

if(!elem) elem = this;

Problem at line 36 character 15: Expected '{' and instead saw 'elem'.

while (elem = elem.offsetParent) {

Problem at line 41 character 17: Expected a conditional expression and inste

ad saw an assignment.

}

Problem at line 47 character 4: Missing semicolon.

Linting ./plugins/subtitle/popcorn.subtitle.js

    } while (obj = obj.offsetParent);

Problem at line 69 character 22: Expected a conditional expression and inste

ad saw an assignment.

Linting ./plugins/webpage/popcorn.webpage.js

  options._iframe  = document.createElement( 'iframe' ),

Problem at line 47 character 60: Missing semicolon.

  options._iframe  = document.createElement( 'iframe' ),

Problem at line 47 character 60: Expected an identifier and instead saw ','.

undefined

Problem at line 47 character 60: Stopping, unable to continue. (57% scanned)

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

People watching this ticket

Referenced by

Pages