lint doesn't check plugins' unit.js files
Right now we are linting the plugin js file (popcorn.wikipedia.js) however we are failing reviews if the unit tests are not written correctly. We need to add popcorn.wikipedia.unit.js to the lint target.
Comments and changes to this ticket
- Milestone order changed from 49 to 0
I saw this and figured I would put something together quickly.
I added 4 new make commands: lint-plugin-tests, lint-player-tests, lint-parser-tests, and lint-unit-tests
The last command runs the previous three.
You'd have to run these commands specifically, so "make lint" would not run the unit tests through JSLint.
I think this would be handy for anybody working on plug-ins, parsers or players, so they can check against lint.
- State changed from super-review-requested to review-looks-good
- Assigned user changed from Scott Downe to Jon Buckley
OK, looks good.
My only real concern was a more general frustration with the complexity of our make system.
I filed a meta like ticket in #550 to figure out better ways of doing this.
- State changed from review-looks-good to staged
Staged in my repo: https://github.com/jbuck/popcorn-js/commit/f9182160033d26bddf3cd6a2...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.