#406 ✓ staged
annasob

lint doesn't check plugins' unit.js files

Reported by annasob | March 14th, 2011 @ 12:15 PM | in 0.7

Right now we are linting the plugin js file (popcorn.wikipedia.js) however we are failing reviews if the unit tests are not written correctly. We need to add popcorn.wikipedia.unit.js to the lint target.

Comments and changes to this ticket

  • David Humphrey

    David Humphrey March 14th, 2011 @ 12:16 PM

    We can add a target for linting unit tests, but I don't want to have this get put into the lint target. Do we really care about lint failing for unit tests?

  • cadecairos

    cadecairos May 30th, 2011 @ 01:53 PM

    • Milestone order changed from “49” to “0”

    I saw this and figured I would put something together quickly.

    I added 4 new make commands: lint-plugin-tests, lint-player-tests, lint-parser-tests, and lint-unit-tests
    The last command runs the previous three.

    here is the commit

    on branch t406

    You'd have to run these commands specifically, so "make lint" would not run the unit tests through JSLint.

    I think this would be handy for anybody working on plug-ins, parsers or players, so they can check against lint.

  • Rick

    Rick May 30th, 2011 @ 02:23 PM

    • Milestone set to 0.7
    • State changed from “new” to “super-review-requested”
    • Assigned user set to “Scott Downe”
    • Milestone order changed from “47” to “0”

    I've pulled the branch and run the targets and I fully agree that these should be added to the Makefile

    PR+

  • Scott Downe

    Scott Downe June 2nd, 2011 @ 10:48 AM

    • State changed from “super-review-requested” to “review-looks-good”
    • Assigned user changed from “Scott Downe” to “Jon Buckley”

    OK, looks good.

    My only real concern was a more general frustration with the complexity of our make system.

    I filed a meta like ticket in #550 to figure out better ways of doing this.

  • Jon Buckley

    Jon Buckley June 2nd, 2011 @ 06:02 PM

    • State changed from “review-looks-good” to “staged”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages