#411 ✓ checked-in
David Humphrey

Ticket #358 regression on wikipedia plugin

Reported by David Humphrey | March 14th, 2011 @ 08:09 PM | in 0.4

18:27 < rwaldron> i have a suspicion that it's breaking http://webmademovies.org/
18:27 < rwaldron> because the carousel is not being created18:27 < rwaldron> and the wikipedia plugin is throwing an exception
18:28 < rwaldron> because an assumption as made about the data being parsed
18:28 < rwaldron> options.src.slice( options.src.lastIndexOf("/")+1)
18:28 < rwaldron> if options.src is not explicitly defined, this throws an exception
18:29 < rwaldron> options.src.slice( options.src && options.src.lastIndexOf("/")+1 || 0 )
18:29 < rwaldron> should fix it
18:29 < rwaldron> annasob: ^^
18:30 <@humph> ( (options.src && options.src.last....) || 0 ) so lint doesn't yell at you
18:31 < annasob> if he gets the latest file it should work
18:31 < rwaldron> the latest file is breaking it
18:32 < annasob> ?if options.src is not explicitly defined, this throws an exception
18:32 < rwaldron> .wikipedia({numOfWords
18:33 < rwaldron> thats his code
18:33 < rwaldron> you might be requiring it, but he's ignoring that requirement

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages