#421 ✓ staged
annasob

player.offset calculated wrong in Vimeo & YouTube

Reported by annasob | March 17th, 2011 @ 02:59 PM | in 0.6

I think this is wrong for situations where the content is embedded within other content vs. the body:

https://github.com/stevenaw/popcorn-js/commit/d3d2801229e941f7b9a43...

You want to look at the node's parent(s) as well, see how we do it in processing.js:

https://github.com/humphd/processing-js/blob/t628/processing.js#L16080

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages