#424 ✓ staged

Static SWFObject in Vimeo and YouTube

Reported by annasob | March 17th, 2011 @ 03:10 PM | in 0.5

Embedding a script copy/pasted from somewhere else is not ideal. If the source script changes we would need to update our files. I think all scrips should be retrieved via getScript()

Comments and changes to this ticket

  • annasob

    annasob March 24th, 2011 @ 04:31 PM

    • Assigned user set to “Steven W”

    Assigning to Steven unless anyone else wants to take a shot. Not sure if this can make 0.5. Steven maybe you can put the links needed to get the SWFObject via getScript

  • Rick

    Rick March 24th, 2011 @ 04:33 PM

    If you're going to do this, SWFObject needs to be hosted on a CDN or some kind of static hosting service, otherwise it defeats the purpose of popcorn.complete.js to require an extra script that isn't a third party api.

  • Steven W

    Steven W March 24th, 2011 @ 05:51 PM

    We'll likely need to store the script in our tree or some other static location somehow. Rick brings up a good point about popcorn.complete, but we don't have a choice either way with SWFObject. The project site is http://code.google.com/p/swfobject/, but the only download links they offer are in zip format. They also request not to link directly to the source files in their SVN repo.

    Maybe if we create a players players/lib directory, we can put it in there?

  • Rick

    Rick March 24th, 2011 @ 05:56 PM

    Hot linking to github is vehemently out of the question. Perhaps mozilla would allow us to host on a cdn of theirs? if not then we can host it at http://popcornjs.org/code/dist as part of the release code (thought, I'm still not fond of that idea )

  • Steven W

    Steven W March 24th, 2011 @ 06:09 PM

    Definitely not a hotlink to the github repo, but I was suggesting if we keep it in the popcorn repo we can then compile it into popcorn.complete. If that's not an option then we'll definitely have to self-host it somewhere.

  • Rick

    Rick March 24th, 2011 @ 06:14 PM

    Interesting alternative... Would be nice to have a way to elegantly compile build steps for plugins if they needed them.

  • Steven W

    Steven W March 31st, 2011 @ 10:17 AM

    • State changed from “new” to “peer-review-requested”

    Either there was a problem between chair and keyboard, or their hosting situation has changed. I think it may be the former. Either way, swfobject is now independently hosted by Google. Updated the players to pull from there. Tested in Chrome 10, Firefox 3.6 and 4.

    Branch: https://github.com/stevenaw/popcorn-js/commit/t424

  • Rick

    Rick March 31st, 2011 @ 09:01 PM

    • Assigned user changed from “Steven W” to “Rick”
  • Rick

    Rick April 14th, 2011 @ 12:16 PM

    • State changed from “peer-review-requested” to “review-looks-good”

    Tested with Players Test Suites and passing 100% in:

    Chrome 9, 10, 11

    Firefox 3.0.12, 3.6.16, 4.0

  • annasob

    annasob April 14th, 2011 @ 04:27 PM

    • State changed from “review-looks-good” to “staged”

    Staged in annasob/popcorn-js commit

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by