#438 ✓ checked-in
David Humphrey

Script load ordering bug

Reported by David Humphrey | March 20th, 2011 @ 05:01 PM | in 0.4.1

In getScript we are loading scripts like this:

    script.src = url;

    script.onload = script.onreadystatechange = function() {
    ...

This is dangerous, since the call to script.src will kick off the load immediately. We should be setting the onload callback handler before we set .src.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages