#450 ✓ staged
Bobby Richter

data-timeline-sources not automatic for <audio>

Reported by Bobby Richter | March 24th, 2011 @ 08:59 AM | in 0.5

Replacing video with audio tag in popcorn parser tests in the following way disables the automatic load of data-timeline-sources:

    <audio id='video' data-timeline-sources="data/data.json"
      controls
      width= '250px'
      poster="../../test/poster.png"> 

      <source id='ogv'
        src="../../test/trailer.ogv"
        type='video/ogg; codecs="theora, vorbis"'> 

      <p>Your user agent does not support the HTML5 Video element.</p>
    </audio>

This code was taken right from the JSON parser test. The audio works fine (as it should), but the some code is skipped because it's not a video anymore. This is probably the culprit:

  document.addEventListener( "DOMContentLoaded", function () { 

    var videos = document.getElementsByTagName( "video" );

    Popcorn.forEach( videos, function ( iter, key ) {

Hindenburg is running into this as they're trying to write some popcorn extensions for their software: #416

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages