#453 ✓ staged
Rick

Lint: Youtube plugin fails JSLint

Reported by Rick | March 24th, 2011 @ 06:17 PM | in 0.5

Linting ./players/youtube/popcorn.youtube.js

      ie = !+"\v1", // feature detection based on Andrea Giammarchi's solution: http://webreflect

ion.blogspot.com/2009/01/32-bytes-to-know-if-your-browser-is-ie.html

Problem at line 49 character 16: Confusing use of '!'.

  function main() {

Problem at line 181 character 20: 'main' was used before it was defined.

            if (!(c[i].nodeType == 1 && c[i].nodeName == "PARAM") && !(c[i].nodeType == 8)) {

Problem at line 399 character 74: Confusing use of '!'.

  timeCheckInterval = 0.5

Problem at line 807 character 30: Missing semicolon.

};

Problem at line 840 character 4: Unnecessary semicolon.

return matches ? matches[0].split( "/e/" )[1] : ""

Problem at line 851 character 53: Missing semicolon.

};

Problem at line 852 character 4: Unnecessary semicolon.

}

Problem at line 921 character 4: Missing semicolon.

    container = document.getElementById( elementId );;

Problem at line 935 character 58: Unnecessary semicolon.

  if ( bytesToLoad == 0 ) {

Problem at line 1220 character 24: Use '===' to compare with '0'.

10 Error(s) found.

Appears to be similar to the vimeo lint issues

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages