#465 ✓ staged
Rick

DRY out repeated options.dataType.toLowerCase() call in Popcorn.xhr

Reported by Rick | April 5th, 2011 @ 09:38 AM | in 0.5

DRY out repeated options.dataType.toLowerCase() call in Popcorn.xhr



if ( options.dataType &&
      ( options.dataType.toLowerCase() === "jsonp" ||
          options.dataType.toLowerCase() === "script" ) ) {

  Popcorn.xhr.getJSONP(
    options.url,
    options.success,
    options.dataType.toLowerCase() === "script"
  );
  return;
}

Should be written as...


options.dataType = options.dataType && options.dataType.toLowerCase() || null;

if ( options.dataType &&
                ( options.dataType === "jsonp" ||
            options.dataType === "script" ) ) {

  Popcorn.xhr.getJSONP(
    options.url,
    options.success,
    options.dataType === "script"
  );
  return;
}

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages