#475 ✓ staged
Steven W

Update players to use getBoundingClientRect

Reported by Steven W | April 13th, 2011 @ 02:44 PM | in 0.5

Changes made by #467 means players need to be updated to define getBoundingClientRect(). These values need to be calculated and not just passed through from the wrapped resource (ie. canvas, Flash object, etc), as subtitle plugins use it before embedded resources have the chance to load.

I've quickly whipped something up for Soundcloud here: https://github.com/stevenaw/popcorn-js/commit/7c635b114d7a7ae314feb...

basePlayer has an implementation already, but it naively assumes the wrapped resource will always be loaded. We need all players to be updated to use this functionality for 0.5, or else subtitling and lowerthird are effectively broken.

I'm not sure whether we should accomplish this through #472, or whether in the interest of time it's better to quickly make each player create it's own implementation.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages