#487 ✓ staged
Rick

Create Static Popcorn.position()

Reported by Rick | April 21st, 2011 @ 11:47 AM | in 0.5

Create static Popcorn.position() that accepts an element argument. Rewire Popcorn.prototype.position() to use static method internally.

This change will allow all plugins and players to use the position() logic for ANY element

Comments and changes to this ticket

  • Rick

    Rick April 21st, 2011 @ 11:54 AM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “Rick” to “annasob”
  • annasob

    annasob April 21st, 2011 @ 12:53 PM

    • State changed from “peer-review-requested” to “super-review-requested”
    • Assigned user changed from “annasob” to “Scott Downe”

    This looks good!
    I ran the core unit tests as well as lowerthird and subtitle as they user this code. PR+
    Chrome, FF 3.6 and 4.0

  • Scott Downe

    Scott Downe April 21st, 2011 @ 01:24 PM

    • State changed from “super-review-requested” to “review-needs-work”
    • Assigned user changed from “Scott Downe” to “Rick”

    Only complaint:

    equals( typeof Popcorn.position, "function" , "Popcorn.position is a provided utility function");
    

    In the utility tests. Trivial.

  • annasob

    annasob April 21st, 2011 @ 05:50 PM

    • State changed from “review-needs-work” to “staged”

    Ok Rick fixed the above.

    Staged in annasob/popcorn-js commit

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages