Flickr plugin variable undefined
The variable, i, in popcorn-js/plugins/flickr/popcorn.flicker.js is initially undefined, and is used as part of the id for a new div.
var containerDiv, _userid, _uri, _link, _image, _count = options.numberofimages || 4 , _height = options.height || "50px", _width = options.width || "50px", _padding = options.padding || "5px", _border = options.border || "0px", i; // create a new div this way anything in the target div is left intact // this is later populated with Flickr images containerDiv = document.createElement( "div" ); containerDiv.id = "flickr"+ i; containerDiv.style.width = "100%"; containerDiv.style.height = "100%"; containerDiv.style.display = "none"; i++;
The variable i should be initialized.
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user changed from Mohammed Buttu to David Seifried
Ready for review branch t515, commit: https://github.com/mbuttu/popcorn-js/commit/0602d8ad1110b41e371d059...
- State changed from review-looks-good to staged
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.