#547 ✓ resolved
Scott Downe

openmap plugin can break popcorn if the internet is slow enough, needs reviewing

Reported by Scott Downe | June 1st, 2011 @ 11:00 AM | in 0.8 (closed)

Right now, with the state of this internet connection I am using, and possibly combined with something on the side of openlayers.org, if the script openLayer.js, I believe, is not downloaded in time, popcorn can error out.

I'm not quite sure what's causing it yet, but I suspect it has to do with the openmaps plugin not waiting for the script.

Only noticeable using popcorn-complete.

We shouldn't error, we should just not display open maps until open maps is ready.

Has anyone else experienced this?

I just had a quick look at the open map plugin, and while there is a isReady, it may have a bug. Also, the start function is twice as long as the setup, and the worries me. This needs to be reviewed.

Comments and changes to this ticket

  • Scott Downe

    Scott Downe June 2nd, 2011 @ 04:59 PM

    • Assigned user set to “cadecairos”

    Me and Chris are going to investigate this, and see if we can get a reduced test case working.

  • cadecairos

    cadecairos June 13th, 2011 @ 02:09 PM

    I cannot seem reproduce this issue on my machine. But I have run into it before.

    After inspecting popcorn.openmap.js I would suggest a re-write of it to move code from start to setup. There is way too much going on in start.

  • Rick

    Rick June 18th, 2011 @ 11:47 AM

    • State changed from “new” to “blocked”

    there is a rewrite ticket open now as well #571

  • cadecairos

    cadecairos June 21st, 2011 @ 10:53 AM

    • Milestone changed from 0.7 to 0.8
    • Milestone order changed from “37” to “0”
  • cadecairos

    cadecairos August 23rd, 2011 @ 11:25 AM

    • State changed from “blocked” to “resolved”

    I think this ticket can be marked resolved, as ticket #571 has been staged, and #663 (in review a.t.m. ) fixes script loading issues inside popcorn complete due to the open map plug-in

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins