Replace Dog + Sintel videos with Popcorn plug vid
The dog has had its day. It bravely jumped through all the hurdles. Thank you, dog. Similarly, Sintel, we love that you are a free movie but we cannot watch your trailer once more.
So in our examples, we should use fallback so folks on Safari and iOS etc can view these. Apparently the MP4 needs to go first or iOS ignores it.
The beep and change happens exactly 2 seconds in, so thats where events should fire.
We should have these in our documentation + tests.
Comments and changes to this ticket
As discussed, the 240x135 height doesn't allow time to be displayed in Chrome because it makes the player too small. So they're now updated to be the same dimesions as is in the fiddle.
However, we should include the other sources. So:
<video height="180"width="300"id="video" controls> <source src="http://videos.mozilla.org/serv/webmademovies/popcornplug.mp4" > <source src="http://videos.mozilla.org/serv/webmademovies/popcornplug.ogv" > <source src="http://videos.mozilla.org/serv/webmademovies/popcornplug.webm" > </video>
This allows it to work on all browsers and iOS devices. The mp4 needs to be first for apple devices.
As for the test suite - just thought it would be cool to have some consistent branding but I don't care that much. Believe it or not some people actually watch the videos, so might be cool to a) have videos that have something to do with our project and b) reinforce or project. But again, not really concerned about it. I just shot some video of popcorn kernels, so figured i'd offer :) They're at:
that video is 1:00 long.
(from [edc9b348f322efc3bf86e44563598e2494254fbb]) [#555] Updated to use new test fixture video https://github.com/rwldrn/popcorn-js/commit/edc9b348f322efc3bf86e44...
- Milestone set to 0.7
- State changed from new to review-needs-work
- Assigned user changed from Rick to Scott Downe
- Milestone order changed from 58 to 0
Test suite update - works perfectly.
Brett - Thanks for making the 1:00 video, I was able to switch out sintel seamlessly.
Updated all docs examples to use:
<video height="180" width="300" id="video" controls> <source src="http://videos.mozilla.org/serv/webmademovies/popcornplug.mp4"></source> <source src="http://videos.mozilla.org/serv/webmademovies/popcornplug.ogv"></source> <source src="http://videos.mozilla.org/serv/webmademovies/popcornplug.webm"></source> </video>
- State changed from review-needs-work to resolved
When we finalize documentation we should encourage plugin authors to take advantage of the change in the visuals of the popcornplug video. 2 seconds in the popcorn "pops" - that would be a good time for the event in a plugin to fire.
- Milestone changed from 0.7 to 0.8
- State changed from resolved to peer-review-requested
- Assigned user changed from Scott Downe to Rick
- Milestone order changed from 40 to 0
Updated to use the popcorntest video. Resources added to repo. All tests are working as expected
(from [b8ac8b235a56a367cbb574e65aaba7cd6036a7d5]) [#555] Replaces sintel with popcorntest (uses same file name to avoid needing to update every test runner) https://github.com/rwldrn/popcorn-js/commit/b8ac8b235a56a367cbb574e...
- Assigned user changed from David Seifried to Jon Buckley
- State changed from super-review-requested to review-looks-good
Yes it works, tests are passing.
I looked at my options, and got some advice from jbuck on the topic of repo health, and I think I'm OK with this. 2MB is not a lot as a one time thing, but if we do things like this again, that 2MB will grow. We should consider this the last media file to go in the repo.
- State changed from review-looks-good to staged
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.