#560 ✓ staged
cadecairos

Option to Hide Youtube Player's controls and annotations

Reported by cadecairos | June 8th, 2011 @ 11:01 AM | in 0.7

The youtube player displays it's native controls by default. according to the Youtube API , you can specify controls: 0 to hide them.

Also, we should consider options to disable annotations. both these options would be desirable in butter, where we have custom controls.

Comments and changes to this ticket

  • cadecairos

    cadecairos June 8th, 2011 @ 11:07 AM

    • State changed from “new” to “assigned”
    • Assigned user set to “cadecairos”
  • cadecairos

    cadecairos June 8th, 2011 @ 05:01 PM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user cleared.

    Here's the branch that enables the toggling of flash controls and annotations

    t560

    to do this you would write:

    popped = Popcorn( Popcorn.youtube( 'video', 'http://www.youtube.com/watch?v=9oar9glUCL0', { width: 400, controls: {0 or 1}, annotations: {1 or 3} } ) );

    for some dumb reason, the annotations flag is 1 for show annotations and 3 for hide. pretty fail.

  • Scott Downe

    Scott Downe June 13th, 2011 @ 12:13 PM

    • Assigned user set to “Scott Downe”
  • annasob

    annasob June 14th, 2011 @ 02:02 AM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “Scott Downe” to “cadecairos”

    No unit tests? Also is this change a typeo:

    attributes = {
    -   id: this.playerId
    +   id: this.player
    };
    

    I searched for this.player and I couldn't find it.
    Tested in Chrome and FF 5.0:

    • lint padded
    • demo worked with and w/o controls
    • original unit tests passed

    If this change is meant to be please comment and set to SR

  • cadecairos

    cadecairos June 17th, 2011 @ 02:24 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “cadecairos” to “annasob”

    I've fixed that accidental change, as well as made a small change to popcorn.youtube.html, so controls are disabled.

  • Rick

    Rick June 18th, 2011 @ 11:50 AM

    • Assigned user changed from “annasob” to “David Seifried”
  • David Seifried

    David Seifried June 20th, 2011 @ 01:22 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “David Seifried” to “cadecairos”

    I'm assuming since chris made the previous change that this is in SR now. Everything looks good code wise, styling is fine, lint passed and works in FF 4 and Chrome.

    I second what Anna said above and that this needs to be represented in the unit tests. After there are some tests this should be good to go.

  • cadecairos

    cadecairos June 20th, 2011 @ 02:19 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “cadecairos” to “David Seifried”

    t560

    Updated with unit tests.

  • David Seifried

    David Seifried June 20th, 2011 @ 03:04 PM

    • State changed from “peer-review-requested” to “review-looks-good”
    • Assigned user changed from “David Seifried” to “Jon Buckley”

    Alright tests look good man, passes lint, tested in FF 4 and Chrome.
    SR+

  • cadecairos

    cadecairos June 20th, 2011 @ 04:48 PM

    t560

    Added a note in the unit test html file about the two youtube videos that will now be present after the tests have completed.

  • Jon Buckley

    Jon Buckley June 20th, 2011 @ 04:50 PM

    • State changed from “review-looks-good” to “staged”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages