Wordriver teardown bug if start was never called
Basically, wordriver's start calls:
options._container.appendChild( options.word );
This is done in start, and not setup, to trigger transitions.
In teardown, we run this:
options._container.removeChild( options.word );
That will error with "Node was not found" code: "8"if start has not been called yet.
Need to call appendChld in setup just to make sure.
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user cleared.
- State changed from super-review-requested to review-looks-good
- Assigned user changed from David Seifried to Jon Buckley
SR+, everything looks good to me, pulled both #561 and this and tested both the unit tests and in butter and everything looks fine.
Tested on FF4 & Chrome 11
- State changed from review-looks-good to staged
Staged in my repo: https://github.com/jbuck/popcorn-js/commit/3a86093014fd62cb4b791a60...
(from [6a24a9b04ecc4c9cbe7f9a6088dfce6e0fa21bbf]) [#562] fixed teardown bug in wordriver https://github.com/rwldrn/popcorn-js/commit/6a24a9b04ecc4c9cbe7f9a6...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.