wordriver plugin broken in ff 3.6
In the wordriver plugin, I am using this code:
document.head.appendChild( span );
That works in FF 4.0 and chrome.
Doesn't in Firefox.
This should be fixed. It also kills popcorn-complete use in 3.6.
Should just use:
document.getElementsByTagName("head").appendChild( span );
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user cleared.
To test: run wordriver in firefox 3.6, should pass with my patch, will fail without.
- State changed from review-looks-good to staged
FF5 is out now, what are we doing supporting FF3.6? :)
Staged in my repo: https://github.com/jbuck/popcorn-js/commit/39e53d2cd54ab57e9fb8d44c...
jbuck, I'm with you on that - but we should support it until mozilla drops support. Currently it's at "latest firefox older version" status: http://viewvc.svn.mozilla.org/vc/libs/product-details/json/firefox_...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.