Cyclic object value error in subtitle
Subtitle references itself.
options.that = this;
We can safely and simply remove that line. It is never used, dead code a fragment of what once was.
There is also a this = this variable in the scope of the plugin that can also be removed.
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user changed from Scott Downe to cadecairos
- State changed from review-looks-good to staged
Staged in my repo: https://github.com/jbuck/popcorn-js/commit/af86d904df2af82f876227b3...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.