#568 ✓ staged
Scott Downe

manifest targets consitency

Reported by Scott Downe | June 10th, 2011 @ 05:05 PM | in 0.7

A lot of our manifests have a string for target, some of these have the first character a capital like subtitle, others a lower case like footnote.

This should be consistent. I vote for all lower case.

Comments and changes to this ticket

  • Scott Downe

    Scott Downe June 10th, 2011 @ 05:19 PM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “Scott Downe” to “cadecairos”

    https://github.com/ScottDowne/popcorn-js/commits/t568

    I also noticed some target names were short names, like wikipedia was wiki-container. We should just use the name of the plugin, no need to save characters.

    Chris, my review man!

  • cadecairos

    cadecairos June 10th, 2011 @ 07:50 PM

    • State changed from “peer-review-requested” to “review-needs-work”

    solid stuff. one odd problem...

    unit tests pass on FX 4

    fail on Chrome 12: these tests fail

    Popcorn plugin - remove plugin

    p.data.trackEvents.byStart is initialized and has 2 entries, expected: 2 result: 1, diff: 2 1
    p.data.trackEvents.byEnd is initialized and has 2 entries, expected: 2 result: 1, diff: 2 1
    p.data.trackEvents.byStart is updated and has 3 entries, expected: 3 result: 2, diff: 3 2
    p.data.trackEvents.byEnd is updated and has 3 entries, expected: 3 result: 2, diff: 3 2
    p2.data.trackEvents.byStart is updated and has 3 entries, expected: 3 result: 2, diff: 3 2
    p2.data.trackEvents.byEnd is updated and has 3 entries, expected: 3 result: 2, diff: 3 2
    p.data.trackEvents.byStart is updated and has 2 entries, expected: 2 result: 1, diff: 2 1
    p.data.trackEvents.byEnd is updated and has 2 entries, expected: 2 result: 1, diff: 2 1

    Not sure if this is due to something you did or something that somehow slipped by.

    confirm you did not break this.. maybe chrome 12 broke something?

    bar time... :D

  • cadecairos

    cadecairos June 10th, 2011 @ 07:50 PM

    • Assigned user changed from “cadecairos” to “Scott Downe”
  • Scott Downe

    Scott Downe June 11th, 2011 @ 07:18 AM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “Scott Downe” to “cadecairos”

    Full pass for me on my home Windows machine in ff 4 and chrome 12. I am guessing you're on Linux?

    Did you try the tests on the same mechine/setup on the develop branch?

    Very odd though. I also do not see anywhere in my code where I touch something that is used by that (or any) core tests.

    getting a full pass on the plugin tests as well.

    Throwing this back to you. Can you confirm this again by running the tests again, then running the tests on develop.

  • Rick

    Rick June 11th, 2011 @ 10:30 AM

    Scott, get out of my head! :D

    Full pass here, too.

  • cadecairos

    cadecairos June 11th, 2011 @ 01:15 PM

    • State changed from “peer-review-requested” to “super-review-requested”
    • Assigned user cleared.

    Yeah I'm using Fedora 15 and Chrome 12. I tried the core tests on the develop branch and got the same failed tests. Must be something browser related, because it passes in Firefox 4 every time.

    Other than that the changes are solid and these fails don't have anything to do with this ticket so PR+

  • Rick

    Rick June 15th, 2011 @ 12:00 PM

    • State changed from “super-review-requested” to “review-looks-good”
    • Assigned user set to “Jon Buckley”

    This seems like it should've been SR+ already

  • Jon Buckley
  • Jon Buckley

    Jon Buckley June 15th, 2011 @ 03:21 PM

    • State changed from “review-looks-good” to “staged”
  • Rick

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages