#644 ✓ staged
Scott Downe

subtitles in multiple instances of popcorn

Reported by Scott Downe | July 6th, 2011 @ 12:36 PM | in 0.8 (closed)

Right now this is throwing an error.

Here is a reduced test case:

<script src="popcorn.js"></script>
<script src="plugins/subtitle/popcorn.subtitle.js"></script>

<video id="video1" controls src="test/trailer.ogv"></video>
<video id="video2" controls src="test/trailer.ogv"></video>

<script>

  var p1 = Popcorn( "#video1" );
  var p2 = Popcorn( "#video2" );

  p1.subtitle({
    start: 0,
    end: 10,
    text: "video one"
  });

  p2.subtitle({
    start: 5,
    end: 15,
    text: "video two"
  });

</script>

This is due to more than one problem inside createDefaultContainer, needs a bit of an overhaul.

This badly needs a test.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages