#645 ✓ staged
brianchirls

code plugin runs onFrame after onEnd

Reported by brianchirls | July 8th, 2011 @ 01:15 PM | in 0.9 (closed)

end sets running to false, but the animation loop function runs onFrame (aliased to f) before checking if it should stop. So onFrame sometimes runs even after onEnd has been called.

          var _f = function() {
            //todo: check running here before calling f()
            f();
            if ( running ) {
              runner( _f );
            }
          };

It may be a good idea to check running again after f returns in case onFrame has changed it. But this is not entirely necessary.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages