#660 ✓ staged
Scott Downe

fix whitespace and quotes in plugins folder

Reported by Scott Downe | July 22nd, 2011 @ 10:36 AM | in 0.9 (closed)

This includes the test, and html files, as well as the plugins themselves.

Comments and changes to this ticket

  • Scott Downe

    Scott Downe August 23rd, 2011 @ 11:15 AM

    • Milestone changed from 0.8 to 0.9
    • Milestone order changed from “36” to “0”
  • Scott Downe

    Scott Downe August 23rd, 2011 @ 11:22 AM

    • no changes were found...
  • Scott Downe

    Scott Downe September 6th, 2011 @ 03:50 PM

    • State changed from “assigned” to “open”
    • Assigned user cleared.
  • David Seifried

    David Seifried September 6th, 2011 @ 05:52 PM

    • State changed from “open” to “assigned”
    • Assigned user set to “David Seifried”
    • Milestone order changed from “9” to “0”
  • David Seifried

    David Seifried September 12th, 2011 @ 08:22 PM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “David Seifried” to “cadecairos”

    Alright, this was done in 2 commits as it was huge but essentially I did the following:

    • Fixed all end of line whitespace in all files for all plugins
    • Fixed any indentation issues
    • Normalized the use of single and double quotes ( where applicable )
    • Fixed any other spacing issues according to the style guide

    Hopefully i didn't miss anything, and sorry for the two part commit.

    https://github.com/dseif/popcorn-js/tree/t660

    P.S im sorry for whoever has to review this :(

  • cadecairos

    cadecairos September 13th, 2011 @ 01:41 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “cadecairos” to “David Seifried”

    Goodbye, Tuesday... no mercy for you dave. :D

    popcorn.attribution.html

    • On line 42: extra space in between attribute and value.
    • On line 47: type='viden/mp4; codecs="avc1, mp4a"'>

    popcorn.attribution.unit.js

    • On line 12: whitespace needed.
    • On line 19: remove space between function name and bracket.
    • On lines 59, 67, 69: remove space between first parameter and comma separator.

    popcorn.code.html

    • On line 68: extra space in between attribute and value.

    popcorn.code.unit.html

    • On line 31: extra space in between attribute and value.

    popcorn.facebook.html

    • On line 72: extra space in between attribute and value.

    popcorn.facebook.unit.html

    • On line 29: extra space in between attribute and value.

    popcorn.facebook.unit.js

    • On line 15, 78: whitespace needed

    popcorn.flickr.html

    • On line 59: extra space in between attribute and value.

    popcorn.flickr.unit.html

    • On line 29: extra space in between attribute and value.

    plugins.footnote.unit.js

    • On line 19: extra space between function name and bracket. "method" spelled wrong.
    • On lines 43, 45, 50, 97: extra space after the first parameter and comma.
    • On line 55: style of second parameter was not corrected.
    • On line 67: extra whitespace in between function keyword and braces

    popcorn.gml.html

    • On line 8: extra whitespace in between function keyword and braces
    • On line 42: extra space

    popcorn.gml.unit.html

    • On line 25: extra space

    popcorn.gml.unit.js

    • On line 12: fix whitespace
    • On line 19: whitespace
    • On lines 46, 51, 53: whitespace before comma

    popcorn.googlefeed.html

    • lines 9, 10, 39: whitespace

    popcorn.googlefeed.js

    • line 82, 179: whitespace

    popcorn.googlefeed.unit.html

    • line 26, 49, 57, 59, 63, 68: whitespace

    popcorn.googlemap.html

    • line 9, 158: whitespace

    popcorn.googlemap.unit.html

    • line 27: whitespace

    popcorn.googlemap.unit.js

    • line 1, 18, 21, 24, 27, 76, 78, 83, 88: whitespace
    • typo on line 18

    popcorn.image.unit.js

    • line 1: whitespace

    popcorn.lastfm.html

    • line 16, 68: whitespace

    popcorn.lastfm.js

    • lines 10-13: whitespace

    popcorn.lastfm.unit.html

    • 29: whitespace

    popcorn.lastfm.unit.js

    • 1, 27, 56, 61, 63, 65, 70, 74, 86: whitespace

    popcorn.linkedin.unit.js

    • 173: extra space

    popcorn.lowerthird.html

    • 10, 12: whitespace

    popcorn.lowerthird.js

    • 32, 63, 122, 126: whitespace

    popcorn.lowerthird.unit.html

    • 27: whitespace

    popcorn.lowerthird.unit.js

    • 111, 18 21: whitespace

    popcorn.mustache.js

    • 87 : whitespace

    popcorn.mustache.unit.html

    • 30: whitespace

    popcorn.mustache.unit.js

    • 1: whitespace

    popcorn.openmap.html

    • 8, 64: whitespace

    popcorn.openmap.js

    • 113: single quotes -> double quotes

    popcorn.openmap.unit.html

    • 25: whitespace

    popcorn.openmap.unit.js

    • 10, 17, 20, 23, 26, 73, 76, 79, 82, 85, 88, 91, 93, 98 : whitespace

    popcorn.pause.html

    • 11, 24: whitespace

    popcorn.pause.unit.html

    • 30, 47: whitespace

    popcorn.pause.unit.js

    • 1, 29, 31, 35, 38, 39, 40, 41, 42, 47, 50, 52, 53, 54, 55, 56, 57, 61, 65: whitespace
    • 58, 59: use double quotes
    • 28, 33: un-indent line
    • 10: use '==='

    popcorn.processing.html

    • 51: whitespace

    popcorn.processing.unit.html

    • 22: whitespace

    popcorn.subtitle.html

    • 8: whitespace

    popcorn.subtitle.unit.html

    • 25, 41: whitespace

    popcorn.subtitle.unit.js

    • 1, 22, 101, 111, 126, 128, 135, 142: whitespace

    popcorn.tagthisperson.html

    • 9, 46: whitespace

    popcorn.tagthisperson.unit.html

    • 26: whitespace

    popcorn.tagthisperson.unit.js

    • 1: whitespace

    popcorn.timeline.html

    • 72: whitespace

    popcorn.timeline.unit.html

    • 27: whitespace

    popcorn.timeline.unit.js

    • 69, 77, 89, 94, 106: whitespace

    popcorn.twitter.html

    • 8, 35: whitespace

    popcorn.twitter.js

    • 37, 85: whitespace

    popcorn.twitter.unit.html

    • 27 : whitespace

    popcorn.twitter.unit.js

    • 1, 22: whitespace

    popcorn.webpage.html

    • 9, 39: whitespace

    popcorn.webpage.js

    • 19, 24, 61: whitespace

    popcorn.webpage.unit.html

    • 27: whitespace

    popcorn.wikipedia.html

    • 9, 37: whitespace
    • 10: mismatching quotes

    popcorn.wikipedia.unit.js

    • 1: whitespace

    popcorn.wordriver.html

    • 8: whitespace

    popcorn.wordriver.js

    • 54: double quotes
    • 82: extra space

    popcorn.wordriver.unit.html

    • 27: whitespace

    popcorn.wordriver.unit.js

    • 1, 20, 23: whitespace

    .............

    All done

  • David Seifried

    David Seifried September 13th, 2011 @ 03:04 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “David Seifried” to “cadecairos”

    Alright fixed everything you mentioned.

    Back to you :D

  • cadecairos

    cadecairos September 14th, 2011 @ 01:43 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “cadecairos” to “David Seifried”

    I ran "make lint-plugin-tests" and found there are many problems with some of the tests. can you fix these? :D

  • David Seifried

    David Seifried September 23rd, 2011 @ 10:49 AM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “David Seifried” to “cadecairos”

    Alright Chris, made all the changes you mentioned. The plugins unit tests and normal js files are all passing lint now!

  • cadecairos

    cadecairos September 23rd, 2011 @ 01:55 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “cadecairos” to “David Seifried”

    lots of merge conflicts... sorry to do this but you need to rebase your branch

  • David Seifried

    David Seifried September 26th, 2011 @ 02:47 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “David Seifried” to “cadecairos”

    Alright rebased chris, same branch as before.

  • cadecairos

    cadecairos September 26th, 2011 @ 03:47 PM

    • State changed from “peer-review-requested” to “super-review-requested”
    • Assigned user changed from “cadecairos” to “Rick”

    This is good.

    as far as I can tell most, if not all whitespace and style issues have been fixed.

    PR+

  • Rick

    Rick September 26th, 2011 @ 04:03 PM

    • State changed from “super-review-requested” to “review-looks-good”
    • Assigned user changed from “Rick” to “cadecairos”

    SR+

    Reviewed diffs +9001

    Tested: core, plugins, players (as best as they could), parsers test suite;

    Passing in:

    • FF 6.x (stable)

    • Chrome 14 (Stable)

    Lint Passes: core, plugins, players, parsers

  • cadecairos
  • Rick

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages