Plugins passing in functions as definitions need to also pass in their manifests
The Popcorn.plugin() method takes 3 arguments: name, definition, and manifest.
Virtually every (if not all) plugins only make use of the first two parameters. This is not a problem as long as the definition parameter is an object literal. There are some plug-ins that pass in anonymous functions to definition, which do not get resolved into objects. This is causing problems in butter, because these plug-ins are not getting a manifest attached to their trackEvents.
We need to move the manifest declarations in the plug-ins passing anonymous functions so that they are the third parameter.
The plugins that need changes are:
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user changed from cadecairos to David Seifried
Alright, I've fixed all the plug-ins that were declaring manifests incorrectly. Several of the ones listed above were not in error so they remained untouched.
see my t669 branch for the changes.
The plug-ins should pass lint and I tested the unit tests for each plug-in I touched, they were al passing.
Nice work identifying this issue and nailing down the solution!
FF 5.x (stable), 7.x (Nightly)
Chrome 12 (stable)
- State changed from review-looks-good to staged
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.