Popcorn.removePlugin fails to remove track events when called on main constructor
Popcorn.removePlugin( type ) on the
general constructor, not on an instance, it removes the plugin from
the registry and returns. It should remove the events from all
According to Scott, the update loop checks that _natives.type
exists, but this doesn't work anymore, since this update:
Comments and changes to this ticket
- Milestone set to 0.8
- State changed from new to assigned
- Assigned user set to Rick
- Milestone order changed from 72 to 0
When calling Popcorn.removePlugin( type ) on the general constructor, not on an instance, it removes the plugin from the registry and returns.
This is the expected and intended behaviour.
The second part, regarding the regression is confirmed. Once the reference is correctly restored, the time update logic will know to remove it. Scott is busy with Popcorn Maker, so I'll take care of this in his stead
(from [c7d774311e2b494b066d71b33cdcfa79ae7de8d4]) [#675] Check registry for potentially removed plugins https://github.com/rwldrn/popcorn-js/commit/c7d774311e2b494b066d71b...
- State changed from review-looks-good to staged
Yeah, dseif's patch just deletes all the code you wrote here. I'll get dseif to rebase
(from [9aa33e83335585d47d63ed74578094d26a1e64bd]) Fix Popcorn.removePlugin not removing track events when called on main constructor [#675] https://github.com/rwldrn/popcorn-js/commit/9aa33e83335585d47d63ed7...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.