#680 ✓ staged
David Humphrey

Closure warnings in players/baseplayer/popcorn.baseplayer.js

Reported by David Humphrey | August 23rd, 2011 @ 12:34 PM | in 0.8 (closed)

I personally like to keep zero warnings in my code, so I'd fix these; though none of them are really a bug. Why not just assign values here?

Building ./dist/popcorn.players.min.js
./players/baseplayer/popcorn.baseplayer.js:18: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
    this.autoplay;
    ^

./players/baseplayer/popcorn.baseplayer.js:19: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
    this.loop;
    ^

./players/baseplayer/popcorn.baseplayer.js:25: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
    this._resource;
    ^

./players/baseplayer/popcorn.baseplayer.js:27: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
    this._container;
    ^

./players/baseplayer/popcorn.baseplayer.js:33: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
    this.offsetParent;
    ^

./players/soundcloud/popcorn.soundcloud.js:397: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
      this._popcorn;
      ^

./players/soundcloud/popcorn.soundcloud.js:412: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
      this.autoplay;
      ^

./players/vimeo/popcorn.vimeo.js:288: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
      this.addEventFn;
      ^

./players/vimeo/popcorn.vimeo.js:289: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
      this.evtHolder;
      ^

./players/youtube/popcorn.youtube.js:312: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
        } else if ( state === YOUTUBE_STATE_CUED ) {
               ^

0 error(s), 10 warning(s)

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages