#704 ✓ staged
brianchirls

end should be called before _teardown when removing a track event

Reported by brianchirls | September 2nd, 2011 @ 10:46 AM | in 1.0 Release (closed)

Currently, if _teardown runs while an event is active, end will not have run.

In theory, a perfectly written plugin would not assume its own state when running _teardown, but it's not safe to make this assumption, and it may require duplicate code to run in both end and _teardown. It's easier and safer to have Popcorn make sure end runs before _teardown on active events.

This would happen in removeTrackEvent and removePlugin.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Tags

Pages