modify Popcorn.protect.natives to protect static and instance methods automatically
Instead of maintaining a list of protected methods we should have all methods on Popcorn.prototype and Popcorn.p.prototype be captured before exposing Popcorn to the global object.
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user changed from cadecairos to Rick
Finally got this ready to go after figuring out a previous test was leaving a method on the prototype. Fixed that issue to fix the tests.
fixed the tests, which will now scale with the API.
- State changed from review-looks-good to staged
(from [5b142310d4c9b050a8837f579d35e58684459cd6]) Modified Popcorn.protect.natives to capture keys from Popcorn.p, added better tests, fixed test polluting the prototype [#738] https://github.com/rwldrn/popcorn-js/commit/5b142310d4c9b050a8837f5...
(from [534d825583101789b97a1bd2b844d51aa6b758f2]) Modified Popcorn.protect.natives to capture all keys on Popcorn.p.prototype. [#738] https://github.com/rwldrn/popcorn-js/commit/534d825583101789b97a1bd...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.