Missing Features in Facebook Plugin
Dseif and I came across this yesterday when going over merge conflicts. We noticed that there was no functionality for the comments type as well as some attributes missing from some of the others as well.
Comments and changes to this ticket
As per our short ic convo last night, I checked this out. Seems to be running ok for me, im getting 2 comments showing up in commentdiv. Are there supposed to be more comments showing up then that? Is there a way to specify how many comments you want to show up?
See for me in both Firefox and Chrome it will cut off the second comment and on. By if no num_posts is specified it is supposed to display 10 with a minimum of 1.
http://img255.imageshack.us/img255/6304/commentissue.jpg That's what it winds up looking like for me.
I'll see if I can today. The problem doesn't seem to be the small screen either because if I place the div to be to the right of the video it has the same result.
- State changed from assigned to peer-review-requested
- Assigned user changed from mjschranz to Rick
Comments Plugin is now added. All unit tests were shorted to be finished in about 6 seconds.
As far as I can tell all the other attributes that are shared across multiple plugins like ref, filter, linktarget or max_age; they aren't really needed for our purposes. I could be wrong here so feel free to correct me if that is the case. https://developers.facebook.com/docs/plugins/
Branch is located here. https://github.com/mjschranz/popcorn-js/tree/t740/plugins/facebook
- State changed from peer-review-requested to super-review-requested
- Assigned user changed from David Seifried to cadecairos
Nice job on this! Few things tho:
- Line 41 has a single end of line whitespace
- Lines 197 & 210 can be removed
Other than these small style changes everything looks good to me.
Passes lint and unit tests pass in FF 7, chrome 14, Safari, and Opera 11.*
after you fix those assign to cadecairos for SR
- State changed from review-needs-work to super-review-requested
- Assigned user changed from mjschranz to cadecairos
Thought I caught all those whitespaces......
- State changed from review-looks-good to staged
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.