#795 ✓ staged
Scott Downe

Youtube player should fire "canplaythrough"

Reported by Scott Downe | October 28th, 2011 @ 01:39 PM | in 1.0 Release (closed)

according to the w3 spec when the media hits readyState = 4 (HAVE_ENOUGH_DATA) a "canplaythrough" event should be triggered. easy fix.

Comments and changes to this ticket

  • Scott Downe

    Scott Downe October 28th, 2011 @ 08:02 PM

    • Assigned user changed from “Scott Downe” to “cadecairos”
    • State changed from “assigned” to “peer-review-requested”
  • cadecairos

    cadecairos October 30th, 2011 @ 05:39 PM

    • Assigned user changed from “cadecairos” to “David Seifried”
    • State changed from “peer-review-requested” to “super-review-requested”

    PR +

    Tested youtube player in:

    Firefox 7, Chrome 15, Safari 5.1

    Passing

    Lint passes

  • David Seifried

    David Seifried October 31st, 2011 @ 10:22 AM

    • Assigned user changed from “David Seifried” to “Scott Downe”
    • State changed from “super-review-requested” to “review-needs-work”

    Can you write some tests for this Scott?

  • Scott Downe

    Scott Downe October 31st, 2011 @ 07:40 PM

    • Assigned user changed from “Scott Downe” to “David Seifried”
    • State changed from “review-needs-work” to “super-review-requested”

    So, I have no good way to test this, unfortunately.

    I cannot make an event without an instance to popcorn, and creating an instance of popcorn may fire the event I am listening for before I can register it.

    I had this same issue in the tests for #782, but solved it with ready state checks to avoid the event. Testing for an event cannot be avoided in the same way.

    Ticket #499 is a good place to consider this issue.

    Going to try to land this without tests, and do everything right post 1.0 in #499.

  • David Seifried

    David Seifried November 1st, 2011 @ 10:33 AM

    • Assigned user changed from “David Seifried” to “cadecairos”
    • State changed from “super-review-requested” to “review-looks-good”

    Alright sounds good as long as this is being addressed and tested for somewhere.

    Youtube unit tests continue to pass in all browsers, style looks good.

    SR+

  • cadecairos

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages