Frame animating popcorn instances continue to run timeupdate after destroyed
There are two execs in the index integrity tests ( setTimeout and frame animation ) that leak after they are run.
Simple fix, going to add
$pop.removePlugin( "exec" );
to each plus function
Comments and changes to this ticket
- Assigned user changed from cadecairos to David Seifried
- State changed from bugs to peer-review-requested
- Title changed from Fix leaking execs in Index integrity tests to Frame animating popcorn instances continue to run timeupdate after destroyed
This turned out to be a lot deeper than we'd first thought.
It seems that destroy was not stopping popcorn instances if they were looping the timeupdate function using frame animation.
Simple fix, inside the frame animation logic, add checks for:
that.isDestroyed && .....()
I'll also modify destroy a bit to check for existence of the timeUpdateFunction ( present on non-frame animating instances )
will write some tests too.
I've been working on this in another ticket: https://webmademovies.lighthouseapp.com/projects/63272/tickets/732-...
There is a lot more to it then even adding
Also, wouldn't it want to check
- State changed from review-looks-good to staged
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.