Comments and changes to this ticket
- Assigned user set to Steven W
- State changed from new to assigned
I checked this out, looks like Opera doesn't append ';' onto the last style when referenced via innerHTML. Fix has been pushed to popcorn-js temporarily, until popcorn-addons is ready.
Tested on Windows in:
Regressions tested against:
Hmm, we had the same problem with the twitter unit tests I believe and I think we just opted to remove the semi-colon from each test so
ok( /display: inline;/.test( flickrdiv.innerHTML ), "Div contents are displayed" );
ok( /display: inline/.test( flickrdiv.innerHTML ), "Div contents are displayed" );
I tested it and It seems to work. Thoughts?
The '\b;?' is in the regex more out of data sanitation paranoia than anything. Removing the semicolon works for all valid css values, but invalid styles also pass ('display: inlined' or 'display: inline block'). Both are good, but it makes sense for consistency to have them all the same.
Feel free to hit this back to PR- if you want me to change it.
- State changed from review-looks-good to staged
- Milestone order changed from 30 to 0
(from [63bf5e32a36a9783a8e6a0e2e417c785b1970326]) [#816] Opera doesn't append ';' onto last style innerhtml https://github.com/rwldrn/popcorn-js/commit/63bf5e32a36a9783a8e6a0e...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.