#830 ✓ staged
Scott Downe

Protected Names unit test doesn't fail, instead hangs

Reported by Scott Downe | November 4th, 2011 @ 11:46 AM | in 1.2 (closed)

In the core unit tests' module "Protected Names", if a name is NOT protected, it doesn't fail, but instead hangs.

  Popcorn.forEach( keys, function( name ) {

    try {
      Popcorn.plugin( name, {} );
    } catch ( e ) {
      ok( name, "Attempting to overwrite '" + name + "' threw an exception " );

We can fix it by adding a

ok(false, "");

just before the catch.

Also, these tests should have a timeout to make sure these tests don't hang again.

Finally, the test inside the catch, uses name as the validation, should just be true.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins