#832 ✓ staged
Scott Downe

defaults don't apply if automatic function is used instead of setup

Reported by Scott Downe | November 5th, 2011 @ 07:07 PM | in 1.2 (closed)

Case where if the alternative way to call setup is used with defaults, the defaults are applied after the setup, and the setup needs to do something with the values inside defaults, so nothing actually gets defaulted properly.

Problem is probably in this line

      return pluginFn.call( this, isfn ? definition.call( this, options ) : definition,
                                  options );

definition.call is the other way to do setup, but the actual setup function is called inside pluginFn.

Possible fix is to apply the defaults before the pluginFn.call.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages