#845 ✓ staged
Scott Downe

parser tests can all be updgraded

Reported by Scott Downe | November 18th, 2011 @ 11:26 AM | in 1.2 (closed)

After reviewing t822, I took a look at the other tests, and they could all use a bit of an update.

Mainly, take advantage of parser callbacks.

All parser tests do something like this:

poppercorn.parseSBV( "data/data.sbv" );

Then have a timeout or polling of some sort to wait until that file is loaded and parsed.

At the time of creating these tests, I suspect parsers did not have callbacks. We should update the tests to fire play on the video inside the callback, that way there is no way a test can fail on a really slow connection because the video passed the point before the parsed file was ready.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages