#893 ✓ resolved
David Seifried

Soundcloud member unit tests need a bit of fixing

Reported by David Seifried | January 16th, 2012 @ 01:22 PM | in 1.2 (closed)

Currently we have a big object containing key value pairs to check the typeof against in our unit tests. This is fine and all, but when we are displaying the results and writing the text out for a test we should use the result of typeof player[prop] instead of just player[prop] as the result can be misleading in some cases ( as I just noticed ). For the autoplay test we are currently failing because we are looking for undefined when in reality the result is actually 'object'. Considering prop === "autoplay", logging player[prop] would yield the result 'null' while logging typeof player[prop] will produce 'object'.

Not a huge deal, but an inconsistency that should be dealt with non the less.

Fix incoming.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages