#918 ✓ staged
Scott Downe

frameAnimation tests should wait for focus

Reported by Scott Downe | February 15th, 2012 @ 10:36 AM | in 1.2 (closed)

This came out of ticket #909.

I was getting seemingly inconsistent and random test failures in frame animation:

Popcorn Plugin: Update Timer (frameAnimation) (1, 0, 1)

Test timed out

Then a different timeout in the same test:

Popcorn Plugin: Update Timer (frameAnimation) (1, 10, 11)

forward's start fired
forward's end fired
wrapper two is running at second 5
wrapper one is stopped at second 5
wrapper two is running at second 6
wrapper one is running at second 6
wrapper two is running at second 7
wrapper one is stopped at second 7
wrapper two is stopped at second 9
wrapper one is stopped at second 9
Test timed out

Then on the third try, it passes.

Turns out it is a focus issue.

The current idea is:

Out test suite has a requirement on focus, so we should be clear with that.

Humph said we could do a waitForFocus(function(){...}) on tests that need focus, if we don't get it, we "Test fails (timeout with reason given as "didn't get focus")."

I think this is a sane solution to a problem that can be quite frustrating and derailing if not obvious to someone.

Thoughts?

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Referenced by

Pages