#934 ✓ staged
Jon Buckley

document Popcorn.smart()

Reported by Jon Buckley | March 4th, 2012 @ 02:24 PM | in 1.2 (closed)

Comments and changes to this ticket

  • Scott Downe

    Scott Downe March 5th, 2012 @ 06:13 PM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “Scott Downe” to “David Seifried”

    https://github.com/ScottDowne/popcorn-docs/commits/smart

    Dave, I need to get access to the jsfiddle, to add a new example.

    I have the example here:

    // create our popcorn instance
    var pop = Popcorn.smart( "#youtube", "http://www.youtube.com/watch?v=v-7kf7OZQtw" );
    
        pop.footnote({
            start: 1,
            end: 15,
            text: "Youtube working!",
            target: "foo"
        });
    
    // play video
    pop.play();
    

    I also need the complete that the docs use to be updated to our newest version, so it can have access to smart.

    This will also be blocked on #939 most likely, so you can even build a version of complete with these methods, which is in turn blocked by ie8 :P

  • David Seifried

    David Seifried March 6th, 2012 @ 08:42 AM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “David Seifried” to “Scott Downe”

    Nice, thanks for doing this Scott. I made some line comments on your commit, but this is almost good to go.

  • Scott Downe

    Scott Downe March 6th, 2012 @ 02:27 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “Scott Downe” to “David Seifried”
  • David Seifried

    David Seifried March 7th, 2012 @ 10:11 AM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “David Seifried” to “Scott Downe”

    One last line comment and then this can be set to SR

  • David Seifried

    David Seifried March 7th, 2012 @ 05:21 PM

    • State changed from “review-needs-work” to “super-review-requested”
    • Assigned user changed from “Scott Downe” to “Jon Buckley”

    PR+

  • Jon Buckley

    Jon Buckley March 8th, 2012 @ 02:02 AM

    • State changed from “super-review-requested” to “review-needs-work”
    • Assigned user changed from “Jon Buckley” to “Scott Downe”

    SR+ once you delete https://github.com/ScottDowne/popcorn-docs/commit/ce54ddb393269a988... which is a nonsense commit that dseif added, then removed from the repo.

    git rebase -i dseif/gh-pages

    then just delete the nonsense commit

  • David Seifried

    David Seifried March 8th, 2012 @ 05:28 PM

    • State changed from “review-needs-work” to “staged”
    • Assigned user cleared.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.

Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.

Shared Ticket Bins

Pages