update makefile to pull in player module and ie8 shim once it lands
Once #895 lands, makefile should be updated to pull this into popcorn-complete. The ie8 shim needs to be included before popcorn.js.
Also, player modules need to be built as well, and included before any players.
I am open to doing this as two tickets because ie8 has not landed yet, but the player module has.
Comments and changes to this ticket
Player module should be fine as is, after taking a quick look at the makefile. We just need something for ie8.
So, for anyone that does not know, the goal here is to not include ie8 in complete, but to have a make ie8 command, that creates a js file that includes ie8, popcorn, player and youtube, in that order.
As things start to support ie8 (plugin) we can add them into the makefile build.
Right now we should only build into ie8 what we support with ie8, which currently is player and youtube.
- State changed from assigned to peer-review-requested
- Assigned user changed from David Humphrey to Scott Downe
This patch adds a new ie8 target, and also adds that target to the main target (e.g., will get called by default when building everything). I've only included the files that are known to work with ie8 (e.g., no plugins yet, until we test them later):
ie8/popcorn.ie8.js popcorn.js modules/player/popcorn.player.js player/youtube/popcorn.youtube.js
- State changed from review-looks-good to staged
(from [63832219acd2eb5b0aef8923e82e05790a228576]) Added Make target for ie8 shim [#939] https://github.com/rwldrn/popcorn-js/commit/63832219acd2eb5b0aef892...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.