Image plugin might load too late and hide its content
As described in IRC...
[11:43 AM] <rwaldron> I'm embedding an image at start: 0 [11:43 AM] <rwaldron> so _setup gets called and start:0 are supposed to be called _immediately_ [11:43 AM] <rwaldron> in _setup there is a load event handler [11:43 AM] <rwaldron> which could occur _after_ start [11:44 AM] <rwaldron> in that load handler... [11:44 AM] <rwaldron> options.anchor.style.display = "none"; [11:44 AM] <rwaldron> so start has fired and displayed the image container [11:44 AM] <rwaldron> (sorry, i changed link to anchor) [11:44 AM] <rwaldron> "".link() is something in DOM [11:45 AM] <rwaldron> so, the load handler executes too late and re-hides the anchor [11:45 AM] <rwaldron> which has the image as a child
Comments and changes to this ticket
- State changed from assigned to peer-review-requested
- Assigned user changed from Rick to Jon Buckley
git checkout -b t960 && git pull git://github.com/rwldrn/popcorn-js.git t960
@jbuck - This will likely conflict with your test suite updates, if so, let me know and I will rebase and resolve when those updates have landed
- State changed from review-looks-good to staged
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Popcorn.js is an HTML5 video framework that lets you bring elements of the web into your videos.
Popcorn.js is a project of Web Made Movies, Mozilla's Open Video Lab.