#236 ✓ staged
mjschranz

Fix Failing Core Tests

Reported by mjschranz | February 3rd, 2012 @ 03:42 PM | in 0.2 - Ghostbusters (closed)

Some seem to be failing and need to be fixed!

Comments and changes to this ticket

  • mjschranz

    mjschranz February 3rd, 2012 @ 04:03 PM

    After running the tests and changing them around a bit to isolate some of them, I noticed that start and end times are not being properly set when Butter.TrackEvent is called. This is causing tests to fail in the 9th group and 15th.

    On top of that, as can be seen by anyone who has run them, it's being reported that the Butter objects don't have setProjectDetails and getProjectDetails methods.

    Looking over what I assume is the appropriate file, I can't actually see them myself.

    Looking into fixes now for the start and end times.

  • Bobby Richter

    Bobby Richter February 3rd, 2012 @ 04:11 PM

    Just to be sure, are you on the design2.0 dev branch? master here is heavily outdated, I believe.

  • mjschranz

    mjschranz February 3rd, 2012 @ 04:19 PM

    I was using the master branch under my fork of popcorn-maker from you, although I imagine that's heavily outdated.

    What would be the appropriate repo then?

    Yeah, butter repo. Durrr.

    Anyway, starting from there :p

  • Bobby Richter

    Bobby Richter February 3rd, 2012 @ 04:22 PM

    Sorry this is so confusing right now. We're trying to bring butter back into its own repo, and have a dev branch to do a lot of the ground work:

    https://github.com/secretrobotron/butter/tree/design2.0

  • Bobby Richter

    Bobby Richter February 3rd, 2012 @ 05:07 PM

    • Milestone set to Design 2.0
  • Bobby Richter

    Bobby Richter February 3rd, 2012 @ 05:07 PM

    • State changed from “assigned” to “resolved”
  • Bobby Richter

    Bobby Richter February 3rd, 2012 @ 05:07 PM

    • State changed from “resolved” to “assigned”
  • Bobby Richter

    Bobby Richter February 4th, 2012 @ 08:03 PM

    • Milestone changed from Design 2.0 to 0.2 - Ghostbusters
  • mjschranz

    mjschranz February 8th, 2012 @ 03:28 PM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “mjschranz” to “David Seifried”
    • Milestone order changed from “1” to “0”
  • Bobby Richter

    Bobby Richter February 8th, 2012 @ 04:36 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “David Seifried” to “mjschranz”

    A comment or two on the commit in the pull request. Lookin' good so far.

  • mjschranz

    mjschranz February 8th, 2012 @ 10:41 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “mjschranz” to “Bobby Richter”

    Fixed that one line.

    Also, the reason why it doesn't fail is because the addTrackEvent code is designed to handle non TrackEvent objects by simply creating a new one. TrackEvents default their name to the generated id along with defaults for start and end if popcornOptions isn't provided. At least, that's what I take from it.

    this.addTrackEvent = function ( trackEvent ){
      if( !( trackEvent instanceof TrackEvent ) ){
        trackEvent = new TrackEvent( trackEvent );
      } //if
      if( _target ){
        _trackEvents.target = _target;
      } //if
      _trackEvents.push( trackEvent );
      trackEvent.track = _this;
      _em.repeat( trackEvent, [
        "trackeventupdated"
      ]);
      trackEvent.track = _this;
      _em.dispatch( "trackeventadded", trackEvent );
      return trackEvent;
    }; //addTrackEvent
    
  • Bobby Richter

    Bobby Richter February 9th, 2012 @ 09:25 AM

    • State changed from “peer-review-requested” to “super-review-requested”
    • Assigned user changed from “Bobby Richter” to “David Seifried”

    Yeah, I thought that was the problem.

  • David Seifried

    David Seifried February 9th, 2012 @ 11:35 AM

    • State changed from “super-review-requested” to “review-needs-work”
    • Assigned user changed from “David Seifried” to “mjschranz”

    This looks great, passes on FF 10, Chrome, Safari and Opera. The only thing that we should probably do while your in this file is to do a bit of cleanup. We have a ton of var declarations that can be simplified for the most part, as well as declaring all variables at the top of each function instead of throughout it. Also the whitespace is a bit all over the place so we can fix that up a bit as well. It wouldn't hurt to add a small comment block over each test to describe it a bit more for others reading it later.

    After that small bit of cleanup this will be good to go.

  • mjschranz

    mjschranz February 9th, 2012 @ 02:14 PM

    • State changed from “review-needs-work” to “super-review-requested”
    • Assigned user changed from “mjschranz” to “David Seifried”

    Done and done.

  • David Seifried

    David Seifried February 9th, 2012 @ 04:32 PM

    • State changed from “super-review-requested” to “review-looks-good”
    • Assigned user changed from “David Seifried” to “Bobby Richter”

    Sweet looks good. SR+

  • Bobby Richter

    Bobby Richter February 10th, 2012 @ 09:55 AM

    • State changed from “review-looks-good” to “staged”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn Maker: Software package encompassing several sub-projects in order to deliver an entire popcorn experience.

Butter: Foundation for Popcorn-powered apps (including Popcorn Maker). Track data management, UI construction, other good stuff.

Cornfield: Server infrastructure to store and share popcorn-and-butter-based user data.

And other projects to allow maximal popcorn usability.

Pages