#2835 ✓ staged
mjschranz

Initial Project Content still being displayed incorrectly

Reported by mjschranz | November 5th, 2012 @ 11:37 PM | in 1.0.2 Tuesday (closed)

TED:

  • Popups - Most aren't having the icon stay relative to the middle of the popup and are favouring positioning themselves farther up from the middle. ( Might be a separate bug itself )
  • 6:29 - Is the text supposed to link directly to a PDF? I just get a google search of a file.
  • 10:42 - Wiki article sitting outside Video (Minor, but it is)
  • 10:54 - Popup under controls
  • 11:09 - Text for Popup hints at it being a clickable link, but there is none

Stop and Frisk:

  • 0:56 - Popup expands outside the canvas
  • 1:45 - Popup under controls
  • 2:27 - Popup expands outside the canvas
  • 2:46 - Popup under controls

Lego Madlib:

  • 1:13 - Exclamation mark get's cut off

Chocolate Bacon:

  • 0:03 - Popup underneath controls
  • 0:20 - Popup underneath controls
  • 0:27 - Popup underneath controls
  • 0:52 - Popup underneath controls
  • 0:55 - Popup underneath controls
  • 1:02 - Popup underneath controls
  • 1:26 - Popup underneath controls
  • 1:43 - Popup underneath controls
  • 1:46 - Popup underneath controls

Internet Bus Tour:

  • 0:11 - Popup underneath controls
  • 0:20 - Popup underneath controls
  • 0:32 - Popup underneath controls
  • 0:41 - Popup underneath controls
  • 1:35 - Popup underneath controls
  • 1:56 - Intended that the popups overlap?
  • 2:18 - Popup underneath controls
  • 3:04 - Popup underneath controls
  • 3:46 - Popup underneath controls
  • 5:07 - Popup underneath controls

Make Magazine:

  • 1:02 - Popup icon outside video
  • 3:57 - Popup icon outside video

101:

  • 0:08 - Probably not intended for the popups to overlap like this.
  • 3:26 - Probably not intended for popup to receive some overlap
  • 4:59 - Probably not intended for popup to receive some overlap

Messing with Maps:

  • 0:37 - Popup underneath the controls

Notice any patterns?

This was all done testing the current landing page on master locally. Chrome, OSX 10.8 etc

Comments and changes to this ticket

  • Brett Gaylor

    Brett Gaylor November 6th, 2012 @ 11:34 AM

    • Assigned user changed from “Brett Gaylor” to “mjschranz”

    I've seen the popup underneath controls things before - there are differences in chrome and firefox related to responsive sizes. If someone places the popups right at the bottom, they may seem different in another browser.

    At any rate, this aren't 1.0 issues, but could you file a seperate ticket for the popups appearing underneath controls? That does seem to be our friend z-index, no?

    though - wouldn't we WANT that? Popups overtop of controls would be even worse. Try this when making new content - if it doesn't happen, close it.

  • mjschranz

    mjschranz November 6th, 2012 @ 11:38 AM

    You're right, it's z-index that places it under the controls and we do want that. I was referring to that it's either a problem with the responsive sizes for the plugin itself or the project needs to be resaved sort of thing (which, technically still is a responsive problem).

  • Brett Gaylor

    Brett Gaylor November 6th, 2012 @ 12:24 PM

    • Milestone cleared.
    • Milestone order changed from “5” to “0”
  • Scott Downe

    Scott Downe November 6th, 2012 @ 12:25 PM

    • Milestone set to 1.0.2 Tuesday
    • Milestone order changed from “1” to “0”

    We should make sure there is no way to position a popup over or under controls.

    If you remix those project, and look at the position, it is somehow positioned outside the video frame.

    I loaded this up on the commit before responsive popup sizes, and it was still there.

  • Scott Downe

    Scott Downe November 6th, 2012 @ 12:25 PM

    • Milestone cleared.
    • Milestone order changed from “9” to “0”

    My bad.

  • Scott Downe

    Scott Downe November 6th, 2012 @ 12:36 PM

    I see what is happening with popups under controls.

    It all depends on the size of the screen.

    If I have a larger screen, and place the popup on the bottom, it'll show up as under controls in a smaller screen. If I place it a the bottom while using a small screen, it'll appear much above the controls and not on top of them like they do with the screen size they were created with.

    I can confirm this is solved when using the responsive popups. Right now, though, re authoring these is going to be a bit of a headache.

    You can re edit old popups without having to worry about them reverting to the new ones, but any new popups created are the new ones. I wonder if we need a convert old popup to new in the editor of old popups to make this authoring easier, so you don't need to copy and paste text between popups.

  • David Humphrey

    David Humphrey November 6th, 2012 @ 04:39 PM

    • Milestone set to 1.0.2 Tuesday
    • Milestone order changed from “1” to “0”

    Moving back to 1.0.2, so we can close 1.0.3

  • mjschranz

    mjschranz November 6th, 2012 @ 05:17 PM

    • State changed from “feedback-requested” to “peer-review-requested”
    • Assigned user changed from “mjschranz” to “Brett Gaylor”
    • Milestone order changed from “12” to “0”

    I've updated the json files for projects we keep in our tree since they are static and can have these changes done to them easily.

    Brett, let me know how these visually look.

  • mjschranz

    mjschranz November 7th, 2012 @ 12:05 PM

    This means people should specifically look at Ted, Frisk, Messing with Maps and Wikkhow
    https://github.com/mozilla/butter/pull/1366

  • Brett Gaylor

    Brett Gaylor November 7th, 2012 @ 01:54 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “Brett Gaylor” to “mjschranz”
    • Milestone order changed from “6” to “0”

    Looks good generally, though these all have a lot of escape characters

    in TED, almost all of the text events have escaped characters

    Stop and frisk:
    At
    2:27

    wikihow
    At
    :45

  • mjschranz

    mjschranz November 7th, 2012 @ 02:09 PM

    • State changed from “review-needs-work” to “peer-review-requested”
    • Assigned user changed from “mjschranz” to “Brett Gaylor”
    • Milestone order changed from “12” to “0”

    Fixed up single/double quotes and apostrophes

  • Brett Gaylor

    Brett Gaylor November 7th, 2012 @ 04:18 PM

    • State changed from “peer-review-requested” to “review-looks-good”
    • Assigned user changed from “Brett Gaylor” to “mjschranz”
    • Milestone order changed from “6” to “0”

    REVIEW LOOKS GOOD.

    Land it.

  • mjschranz

    mjschranz November 7th, 2012 @ 07:34 PM

    • State changed from “review-looks-good” to “staged”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn Maker: Software package encompassing several sub-projects in order to deliver an entire popcorn experience.

Butter: Foundation for Popcorn-powered apps (including Popcorn Maker). Track data management, UI construction, other good stuff.

Cornfield: Server infrastructure to store and share popcorn-and-butter-based user data.

And other projects to allow maximal popcorn usability.

Pages