#2851 ✓ staged
mjschranz

Save button in header can still be clicked during initial loading

Reported by mjschranz | November 7th, 2012 @ 02:04 PM | in 1.0.2 Tuesday (closed)

Until media is ready, it should be disabled.

Comments and changes to this ticket

  • mjschranz

    mjschranz November 7th, 2012 @ 02:26 PM

    • State changed from “assigned” to “peer-review-requested”
    • Assigned user changed from “mjschranz” to “Scott Downe”
    • Milestone order changed from “14” to “0”
  • Scott Downe

    Scott Downe November 7th, 2012 @ 03:58 PM

    • State changed from “peer-review-requested” to “review-needs-work”
    • Assigned user changed from “Scott Downe” to “mjschranz”
    • Milestone order changed from “4” to “0”

    So, talked in person.

    Do that, and put in SR.

  • mjschranz

    mjschranz November 7th, 2012 @ 03:58 PM

    • State changed from “review-needs-work” to “super-review-requested”
    • Assigned user changed from “mjschranz” to “Jon Buckley”
    • Milestone order changed from “12” to “0”

    To Jon

  • David Humphrey

    David Humphrey November 7th, 2012 @ 03:59 PM

    • Assigned user changed from “Jon Buckley” to “David Humphrey”
    • Milestone order changed from “8” to “0”

    Stealing

  • David Humphrey

    David Humphrey November 7th, 2012 @ 04:03 PM

    • State changed from “super-review-requested” to “review-needs-work”
    • Assigned user changed from “David Humphrey” to “mjschranz”
    • Milestone order changed from “6” to “0”

    This has some odd behaviour compared to the Preview button in the share editor. If I've ever saved, the Publish in the Share editor will always work, since my last save is still preview-able. What happens in the header now is that the Preview gets disabled after the project goes dirty.

    Why are we changing that in this patch? Can you split this up and just fix the one bug here so we can get this landed? Let's deal with state on Preview in 1.1. I'm out of time to do more reviews.

  • mjschranz

    mjschranz November 7th, 2012 @ 04:18 PM

    • State changed from “review-needs-work” to “super-review-requested”
    • Assigned user changed from “mjschranz” to “David Humphrey”
    • Milestone order changed from “12” to “0”

    Kept it simple. Make the default state of the header layout what we want it to be rather than have that logout call.

  • David Humphrey

    David Humphrey November 7th, 2012 @ 04:21 PM

    • Assigned user changed from “David Humphrey” to “Scott Downe”
    • Milestone order changed from “6” to “0”

    SR+, but let Scott sign off since it changed.

  • mjschranz

    mjschranz November 7th, 2012 @ 04:27 PM

    • State changed from “super-review-requested” to “review-looks-good”
    • Assigned user changed from “Scott Downe” to “mjschranz”
    • Milestone order changed from “4” to “0”

    Scott says SR+

  • mjschranz

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Popcorn Maker: Software package encompassing several sub-projects in order to deliver an entire popcorn experience.

Butter: Foundation for Popcorn-powered apps (including Popcorn Maker). Track data management, UI construction, other good stuff.

Cornfield: Server infrastructure to store and share popcorn-and-butter-based user data.

And other projects to allow maximal popcorn usability.

Pages